cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From petermetz <>
Subject [GitHub] cordova-plugin-splashscreen pull request #107: Browser platform brought clos...
Date Sun, 26 Jun 2016 11:01:31 GMT
GitHub user petermetz opened a pull request:

    Browser platform brought closer to iOS/Android behaviour

    ### Platforms affected
    ### What does this PR do?
    One bug-fix and 2 small features added that were already there for other platforms.
    ### What testing has been done on this change?
    Went few the obvious permutations of the affected configuration parameters and checked
them working on the following user agents:
    * Chrome - 51.0.2704.103 (64-bit) - El Capitan, Macbook Pro
    * Firefox - 47.0 - El Capitan, Macbook Pro
    * Chrome 51.0.2704.81 - Android 5.1.1., Nexus 10
    * Mobile Safari - iOS 9, iPhone 6
    ### Checklist
    - [ x ] [ICLA]( has been signed and submitted
    - [ x ] [Reported an issue]( in the JIRA
    - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving
file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ x ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
commit dbd1e8b2608a47a773a559901345c25cd7bc31ac
Author: Peter (Somogyvari) Metz <>
Date:   2016-06-26T10:41:44Z

    CB-11486 (browser) splashScreenDelay now feed through parseInt to ensure it's an integer
by the time it's value is passed in to setTimeout() in hide().

commit 795e5fe6bb6fb5dabeaec9eb42fa72ebfbb6f6a8
Author: Peter (Somogyvari) Metz <>
Date:   2016-06-26T10:45:43Z

    CB-11487 (browser) The "standard" AutoHideSplashScreen config.xml property is now supported
by the browser platform.

commit 97cecc3f56d19c83a431d453c39a61f24d882c1d
Author: Peter (Somogyvari) Metz <>
Date:   2016-06-26T10:49:08Z

    CB-11488 (browser) Added a 1 second long fade out to the splash screen instead of the
hard remove from the DOM whenever hide() is called.
    Also made a high z-index the default. This could be added from the user's stylesheets
but if that only
    gets parsed later, there may be flickering between the application UI and the splash screen


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message