cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jonathanli2 <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...
Date Mon, 13 Jun 2016 15:25:38 GMT
GitHub user jonathanli2 opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/105

    fix bug CB-11422 ios SplashScreen plugin may make webview disabled by…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    ios
    
    ### What does this PR do?
    Fix bug CB-11422 ios SplashScreen plugin may make webview disabled by splash screen plugin
    
    ### What testing has been done on this change?
    Testing with an ios cordova project with splash screen.
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    Yes
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    Yes
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    Yes
    - [ ] Added automated test coverage as appropriate for this change.
    
    … not calling destroyView method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jonathanli2/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit 60e3e3381ab0a9481e62fc305919e9c8d0930ab7
Author: Jonathan Li <jonathan.li@sap.com>
Date:   2016-06-13T15:05:35Z

    CB-11422: (ios): SplashScreen plugin may make webview disabled by not calling destroyView
method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message