cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords
Date Fri, 17 Jun 2016 04:34:41 GMT
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-plugin-dialogs/pull/71
  
    Interesting, and useful. However, you cannot simply shoehorn your api into another value.

    I suggest you add your new boolean to the end of the args:
    navigator.notification.prompt(message, promptCallback, [title], [buttonLabels], [defaultText],
[secureInput])
    
    The only downside then is just that app developers would have to supply defaultText, but
they could just use "" so no biggie.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message