cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality
Date Thu, 09 Jun 2016 20:15:26 GMT
Github user riknoll commented on the issue:

    https://github.com/apache/cordova-lib/pull/449
  
    @ktop Run `git log` and check out the author field. Your email shows up, but the name
is unknown for some reason.
    
    As for the force add thing, that sounds fine to me. There are two possible behaviors:
    
    1. When you force add a plugin, remove any existing changes (i.e. the changes of plugin
1) and apply the new changes (from plugin 2)
    2. When you force add a plugin, ignore any conflicting changes (i.e. the changes of plugin
2) and leave the existing ones in place (from plugin 1)
    
    I believe you are describing the first behavior. The difference between that and the current
implementation is that the current implementation shouldn't store both sets of changes in
platform.json. If the changes of plugin 1 get overwritten by plugin 2, then they should be
undone before the changes of plugin 2 are made. Otherwise, the platform.json gets into a weird
state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message