cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality
Date Thu, 09 Jun 2016 19:01:17 GMT
Github user riknoll commented on the issue:

    https://github.com/apache/cordova-lib/pull/449
  
    I've tested it out and I think there needs to be a slight tweak to the `--force` behavior.
When a plugin is force added, any conflicting edit-config changes it has should not be applied.
Otherwise, you can get into a weird situation where adding conflicting plugins and removing
them in a bad order results in the config file being different than when you started.
    
    For example, If I have two plugins that conflict and I execute the following commands:
    ```
    cordova plugin add plugin-1
    cordova plugin add plugin-2 --force
    cordova plugin rm plugin-1
    cordova plugin rm plugin-2
    ```
    I will be left with a config file  that has the changes that `plugin-1` made despite `plugin-1`
no longer being in my project. I think it's a good idea to always make it so that removing
all plugins will get you back to where you started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message