Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 116492009C6 for ; Tue, 31 May 2016 19:01:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0FB86160A44; Tue, 31 May 2016 17:01:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 330B11609AD for ; Tue, 31 May 2016 19:01:40 +0200 (CEST) Received: (qmail 60880 invoked by uid 500); 31 May 2016 17:01:39 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 60868 invoked by uid 99); 31 May 2016 17:01:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 17:01:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 84173CAD8C for ; Tue, 31 May 2016 17:01:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.103 X-Spam-Level: X-Spam-Status: No, score=-0.103 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id DUFGtcenbQhV for ; Tue, 31 May 2016 17:01:36 +0000 (UTC) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0123.outbound.protection.outlook.com [65.55.169.123]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 778D15F4E3 for ; Tue, 31 May 2016 17:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QUlWEs0QXsCC8UHxweQWqEQlDp0cCuFazmlc/K5CRPw=; b=afek0B7XacW+CdqDVaRysBKalTeBEA94bBObtIQfSKACmBjwSCOMqnnndVp82qk9f0L72Gn2i4VxFHxZYbDa3lL24uyrgwrW8QFXy2YrIOS00X8Mb/Avi5NRlEuFlLdPdYVbZlPqND5rQRfdsCmTpI+2t1iiAshCdhCnu72Gzzc= Received: from SN2PR03MB2142.namprd03.prod.outlook.com (10.166.209.27) by SN2PR03MB2142.namprd03.prod.outlook.com (10.166.209.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.506.9; Tue, 31 May 2016 17:01:34 +0000 Received: from SN2PR03MB2142.namprd03.prod.outlook.com ([10.166.209.27]) by SN2PR03MB2142.namprd03.prod.outlook.com ([10.166.209.27]) with mapi id 15.01.0506.013; Tue, 31 May 2016 17:01:34 +0000 From: Jason Ginchereau To: "dev@cordova.apache.org" Subject: RE: NPM v3 packaging issues Thread-Topic: NPM v3 packaging issues Thread-Index: AdG7CUDwjczlfxFGQRyyX98KtnIXUQAUqHGw Date: Tue, 31 May 2016 17:01:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cordova.apache.org; dkim=none (message not signed) header.d=none;cordova.apache.org; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2001:4898:80e8:b::6ba] x-ms-office365-filtering-correlation-id: f9343d2d-a2ba-4103-7a7f-08d389753874 x-microsoft-exchange-diagnostics: 1;SN2PR03MB2142;5:g4u4oztKb7Klyn39O+7vZtnk0bu+KhZFPSDwDeD/Zx8tFCSzyLPLuj51whFO57Iby0aBQnsI3WNsZOhXVaOJboPdQexb1B8TiXk88nrLCg8Cgl+9JRzI6Mspj43o/GNP+nEy2KFxUWMoBmXZnglM8w==;24:8hsHHDF2frggwEzKrJj6U/jr+77Ziz+3ZxB0hT67OeGkWbKkjSqWv2kkvxez6dmOqoyr7LPMYCuJ9szVP6i+Dzz9bVbWON3Q+dhlgczGqhc=;7:+tDSey52C2B6Ji/mKyODjGi3sKXeRj0+668Q1O57tfDeyZNzwoGh7xXJ+RchTk3QRk9/6J0sjgiDAh++ZgaeDmV7UQ+UnigLZYmnXfEFfgt5zqHyeQin+ZIvT5fM3o65KtmgTODVvp17maIrkXTPwiqaQBbPg5pE5U+bVm/6Ix5hUIHGeWvEiR64O4qyJEP21dZKajOqTph8UR9F0atrtA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB2142; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(61426038)(61427038);SRVR:SN2PR03MB2142;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB2142; x-forefront-prvs: 095972DF2F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(13464003)(5003600100002)(92566002)(8990500004)(122556002)(2900100001)(10290500002)(5002640100001)(10400500002)(2906002)(102836003)(6116002)(15975445007)(586003)(5005710100001)(2950100001)(19580405001)(19580395003)(74316001)(81166006)(8936002)(8676002)(1730700003)(5004730100002)(99286002)(110136002)(107886002)(10090500001)(2351001)(87936001)(450100001)(77096005)(5008740100001)(76576001)(54356999)(50986999)(76176999)(2501003)(189998001)(33656002)(3280700002)(9686002)(3660700001)(11100500001)(86362001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR03MB2142;H:SN2PR03MB2142.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2016 17:01:33.8520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2142 archived-at: Tue, 31 May 2016 17:01:41 -0000 Could npm shrinkwrap be a solution? The cordova-coho docs mention shrinkwra= p was avoided previously because it was "not mature", but it has apparently= improved a lot in v3. According to a comment [1] in another related issue = it has solved this problem in v3. I'm not totally familiar with the platfor= m versioning and packaging strategy though so I may be missing something. [1] https://github.com/npm/npm/issues/11287#issuecomment-175262681 Jason -----Original Message----- From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]=20 Sent: Tuesday, May 31, 2016 12:11 AM To: dev@cordova.apache.org Subject: NPM v3 packaging issues Hey, guys We've just ran into issue, caused by NPM v3 flat directory structure. The i= ssue is that NPM does not pack sub-dependencies of bundled dependencies int= o resultant archive. This only affects flatten dependency trees, but we alr= eady switched to that in platform repos. As an example, we have 'elementtree' dependency in cordova-windows, which d= epends on 'sax'. After running 'npm install' these dependencies installed a= s a siblings into 'node_modules', but after running 'npm pack' (in particul= ar - 'coho create-archive') the resultant .tgz contains ONLY 'elementtree' = but not 'sax'. Related NPM issue is https://github.com/npm/npm/issues/8474 AFAIK, the only solution for now is to revert 'node_modules' structure back= to tree form. - Best regards, Vladimir --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org