Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BA30D2009F9 for ; Mon, 23 May 2016 18:38:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B8E50160A0E; Mon, 23 May 2016 16:38:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0638C160A05 for ; Mon, 23 May 2016 18:38:43 +0200 (CEST) Received: (qmail 73522 invoked by uid 500); 23 May 2016 16:38:43 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 73510 invoked by uid 99); 23 May 2016 16:38:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2016 16:38:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C9AA9DFC8C; Mon, 23 May 2016 16:38:42 +0000 (UTC) From: nikhilkh To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-windows pull request: Fix build result when using --bundle... Content-Type: text/plain Message-Id: <20160523163842.C9AA9DFC8C@git1-us-west.apache.org> Date: Mon, 23 May 2016 16:38:42 +0000 (UTC) archived-at: Mon, 23 May 2016 16:38:44 -0000 Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/175#issuecomment-221026158 @georgeslegros Thanks for this fix! It will be great to not add a dependency to lodash for this - also as you have not added it to package.json - our tests are failing. It will be great if you can create a JIRA here about the issue with details on how to reproduce it - this will help in testing this fix: https://issues.apache.org/. Please follow instructions here on how to file a JIRA: http://cordova.apache.org/contribute/issues.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org