Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: ktop <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-432-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-432-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Content-Type: text/plain
Message-Id: <20160519173921.F22EDDFADD@git1-us-west.apache.org>
Date: Thu, 19 May 2016 17:39:21 +0000 (UTC)
archived-at: Thu, 19 May 2016 17:39:23 -0000

Github user ktop commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/432#discussion_r63922339
  
    --- Diff: cordova-lib/src/cordova/prepare.js ---
    @@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot, options) {
                         var browserify = require('../plugman/browserify');
                         return browserify(project, platformApi);
                     }
    +            })
    +            .then(function () {
    +                // Handle config-file in config.xml
    +                var platformRoot = path.join(projectRoot, 'platforms', platform);
    +                var platformJson = PlatformJson.load(platformRoot, platform);
    +                var munger = new PlatformMunger(platform, platformRoot, platformJson);
    +                munger.add_config_changes(project.projectConfig, /*should_increment=*/true).save_all();
    --- End diff --
    
    Thanks for reviewing, I'll make the change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org