Return-Path: <dev-return-60617-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 9D969200ACA
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 19 May 2016 00:38:43 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 9C058160A15; Wed, 18 May 2016 22:38:43 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E409B160A00
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 19 May 2016 00:38:42 +0200 (CEST)
Received: (qmail 86707 invoked by uid 500); 18 May 2016 22:38:42 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 86696 invoked by uid 99); 18 May 2016 22:38:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2016 22:38:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id AD561DFBDE; Wed, 18 May 2016 22:38:41 +0000 (UTC)
From: riknoll <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-432-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-432-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Content-Type: text/plain
Message-Id: <20160518223841.AD561DFBDE@git1-us-west.apache.org>
Date: Wed, 18 May 2016 22:38:41 +0000 (UTC)
archived-at: Wed, 18 May 2016 22:38:43 -0000

Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-220179183
  
    @ktop I have a couple questions. First, do we have a plan for dealing with plugins that have conflicting attribute edits? For example, if plugin A has this in its plugin.xml:
    
    ```xml
    <config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
        <uses-sdk android:maxSdkVersion="22" />
    </config-file>
    ```
    
    and plugin B has this in its plugin.xml:
    
    ```xml
    <config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
        <uses-sdk android:maxSdkVersion="17" />
    </config-file>
    ```
    
    Will the user get a build error?
    
    Second, is it possible to reference a sibling of the same tag type? For example, given this in my AndroidManifest.xml:
    
    ```xml
    <application android:icon="@drawable/icon" android:label="@string/app_name">
        <activity
            android:label="@string/activity_name"
            android:name="MainActivity" />
        <activity
            android:label="@string/second_activity"
            android:name="SecondActivity" />
    </application>
    ```
    
    If I wanted to add an attribute in the second Activity, how would I do so? This isn't a real-life example, but you get the idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org