Return-Path: <dev-return-60344-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 2550B2009C5
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 16 May 2016 10:38:24 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 2420D160A16; Mon, 16 May 2016 08:38:24 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 6C0B01609B0
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 16 May 2016 10:38:23 +0200 (CEST)
Received: (qmail 52058 invoked by uid 500); 16 May 2016 08:38:22 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 52047 invoked by uid 99); 16 May 2016 08:38:22 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 May 2016 08:38:22 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 25308DFB90; Mon, 16 May 2016 08:38:22 +0000 (UTC)
From: jcesarmobile <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-209-cordova-plugin-camera@git.apache.org>
In-Reply-To: <git-pr-209-cordova-plugin-camera@git.apache.org>
Subject: [GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...
Content-Type: text/plain
Message-Id: <20160516083822.25308DFB90@git1-us-west.apache.org>
Date: Mon, 16 May 2016 08:38:22 +0000 (UTC)
archived-at: Mon, 16 May 2016 08:38:24 -0000

Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63323857
  
    --- Diff: appium-tests/helpers/cameraHelper.js ---
    @@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
         }, opts);
     };
     
    -module.exports.checkPicture = function (pid, cb) {
    +// verifies taken picture when the promise is resolved,
    +// calls a callback with 'OK' if everything is good,
    +// calls a callback with 'ERROR: <error message>' if something is wrong
    +// note that this function is executed in the context of tested app
    +// and not in the context of tests
    +module.exports.checkPicture = function (pid, options, cb) {
    +    var isIos = cordova.platformId === "ios";
    +    var isAndroid = cordova.platformId === "android";
    +    // skip image type check if it's unmodified on Android:
    +    // https://github.com/apache/cordova-plugin-camera/#android-quirks-1
    +    var skipFileTypeCheck = isAndroid &&
    +        (!options.quality || options.quality === 100) &&
    --- End diff --
    
    @riknoll the truth is quality default is 50 for all platforms as if no quality option is passed, Camera.js set it to 50 (https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js#L145). Even if the java code sets the default to 80 it will be 50 (I have tested). Anyway, I'm going to open an issue and set it 50 in the java code too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org