Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-177-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-177-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...
Content-Type: text/plain
Message-Id: <20160513191759.DB006DFC4F@git1-us-west.apache.org>
Date: Fri, 13 May 2016 19:17:59 +0000 (UTC)
archived-at: Fri, 13 May 2016 19:18:01 -0000

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/177#discussion_r63237158
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -362,6 +362,36 @@ module.exports.run = function () {
         });
     };
     
    +/** Checks if Windows SDK required to build the target_platform is present
    + * @param {String}  target_platorm        Target platform ('8.1' or '10.0')
    + * @return {Boolean}                      Whether the min SDK required to build the platform is present  
    + *
    + */ 
    +module.exports.isWinSDKPresent = function (target_platform) {
    +    return getInstalledWindowsSdks()
    +    .then(function (installedSdks) {
    +        var reqVersion = Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
    +        var hasSdkInstalled = installedSdks.some(function (installedSdk) {
    --- End diff --
    
    same goes for ```isPhoneSDKPresent()```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org