Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-247-cordova-cli@git.apache.org>
In-Reply-To: <git-pr-247-cordova-cli@git.apache.org>
Subject: [GitHub] cordova-cli pull request: Telemetry
Content-Type: text/plain
Message-Id: <20160510214608.805C0DFBDE@git1-us-west.apache.org>
Date: Tue, 10 May 2016 21:46:08 +0000 (UTC)
archived-at: Tue, 10 May 2016 21:46:10 -0000

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/247#discussion_r62758588
  
    --- Diff: spec/cli.spec.js ---
    @@ -50,19 +56,34 @@ describe("cordova cli", function () {
                 beforeEach(function () {
                 });
     
    -            it("will spit out the version with -v", function () {
    -                cli(["node", "cordova", "-v"]);
    -                expect(console.log.mostRecentCall.args[0]).toMatch(version);
    +            it("will spit out the version with -v", function (done) {
    +                cli(["node", "cordova", "-v"]).then(function() {
    +                    expect(console.log.mostRecentCall.args[0]).toMatch(version);
    +                    done();
    +                }).fail(function() {
    --- End diff --
    
    They have changed because ```telemetry.showPrompt()``` is async, therefore the return of ```cli``` turned into async, and the tests had to be updated to reflect that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org