Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-303-cordova-android@git.apache.org>
In-Reply-To: <git-pr-303-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-11198 Skip android target sdk che...
Content-Type: text/plain
Message-Id: <20160505235204.77E35DFCE0@git1-us-west.apache.org>
Date: Thu,  5 May 2016 23:52:04 +0000 (UTC)
archived-at: Thu, 05 May 2016 23:52:06 -0000

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/303#discussion_r62273198
  
    --- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
    @@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
         var args = this.getArgs(opts.buildType == 'debug' ? 'debug' : 'release', opts);
         return check_reqs.check_ant()
         .then(function() {
    -        return spawn('ant', args, {stdio: 'inherit'});
    +        return spawn('ant', args, {stdio: 'pipe'});
    +    }).progress(function (stdio){
    --- End diff --
    
    Can you elaborate? As far as I can see superspawn only returns `stderr` output only if you 'pipe'. Piping implies that someone has to still write this to process.stdout & process.stderr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org