Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CAC222009D9 for ; Mon, 2 May 2016 21:29:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C945B1609B1; Mon, 2 May 2016 21:29:16 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 441231609B0 for ; Mon, 2 May 2016 21:29:16 +0200 (CEST) Received: (qmail 79131 invoked by uid 500); 2 May 2016 19:29:15 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 78839 invoked by uid 99); 2 May 2016 19:29:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 19:29:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6F83EDFB81; Mon, 2 May 2016 19:29:14 +0000 (UTC) From: purplecabbage To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-windows pull request: CB-10653 Making the windows activati... Content-Type: text/plain Message-Id: <20160502192914.6F83EDFB81@git1-us-west.apache.org> Date: Mon, 2 May 2016 19:29:14 +0000 (UTC) archived-at: Mon, 02 May 2016 19:29:17 -0000 Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61789809 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,9 @@ module.exports = { // OR cordova.require('cordova/platform').activationContext // activationContext:{type: actType, args: args}; var activationHandler = function (e) { - var args = e.detail.arguments; - var actType = e.detail.type; - platform.activationContext = { type: actType, args: args }; + // Making all the details available as activationContext + platform.activationContext = utils.clone(e.detail); + platform.activationContext.args = e.detail.arguments; /* for backwards compatibility */ --- End diff -- I just mean that we have gone thru the trouble of using utils.clone, which to me implies that we want a shallow copy, and then we were also passing a deep copy of arguments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org