Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: rakatyal <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-173-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-173-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Content-Type: text/plain
Message-Id: <20160502175138.8AC51DFC77@git1-us-west.apache.org>
Date: Mon,  2 May 2016 17:51:38 +0000 (UTC)
archived-at: Mon, 02 May 2016 17:51:40 -0000

Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/173#discussion_r61774665
  
    --- Diff: cordova-js-src/platform.js ---
    @@ -56,9 +57,10 @@ module.exports = {
                 // OR cordova.require('cordova/platform').activationContext
                 // activationContext:{type: actType, args: args};
                 var activationHandler = function (e) {
    -                var args = e.detail.arguments;
    -                var actType = e.detail.type;
    -                platform.activationContext = { type: actType, args: args };
    +                // Making all the details available as activationContext
    +                platform.activationContext = utils.clone(e.detail); 
    +                platform.activationContext.args = e.detail.arguments;       /* for backwards compatibility */
    +                platform.activationContext.actType = e.detail.type;         /* for backwards compatibility */
    --- End diff --
    
    That's right! Corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org