Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: kenichi-fukushima <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-7-cordova-plugin-wkwebview-engine@git.apache.org>
In-Reply-To: <git-pr-7-cordova-plugin-wkwebview-engine@git.apache.org>
Subject: [GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...
Content-Type: text/plain
Message-Id: <20160502065447.C5474DFDD0@git1-us-west.apache.org>
Date: Mon,  2 May 2016 06:54:47 +0000 (UTC)
archived-at: Mon, 02 May 2016 06:54:50 -0000

Github user kenichi-fukushima commented on the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-216118441
  
    A drive-by comment:
    In our app, we ended up subclassing CDVWKWebViewEngine and creating another instance of WKWebView in -pluginInizialize so that we can use configuration values that we want. I'd suggest factoring out the code to create WKWebViewConfiguration to another method so that Cordova users can customize the logic by code rather than static configurations in a file. This means you can't create a web view instance in the initializer any more. This is OK because CDVWKWebViewEngine doesn't have to conform to the usual plugin semantics and you can add a factory method like -webView.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org