cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From psiolent <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Make moveFile() always copy ins...
Date Mon, 09 May 2016 14:40:44 GMT
GitHub user psiolent opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/96

    Make moveFile() always copy instead of rename.

    Rename fails in Android when moving between file systems. This meant recorded files always
had to be saved to same file system as temp recording file. Always copying (as opposed to
choosing to rename in the case of only one recorded file) removes this limitation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/psiolent/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 4469768dd4b26c12e04d0330e00c3899adb4e0ec
Author: Aja Walker <aja@ajawalker.com>
Date:   2016-05-09T14:38:47Z

    Make moveFile() always copy instead of rename.
    
    Rename fails in Android when moving between file systems. This meant recorded files always
had to be saved to same file system as temp recording file. Always copying (as opposed to
choosing to rename in the case of only one recorded file) removes this limitation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message