cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From serbanghita <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: [Windows] Separated CSS from ...
Date Wed, 04 May 2016 15:28:53 GMT
GitHub user serbanghita opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/74

    [Windows] Separated CSS from JS code. Fixed prompt UI

    Fixed the prompt dialog CSS to look close to native.
    Fixed the positioning of the prompt dialog for Windows.
    
    **How to test**
    
    1. cordova create myApp
    1. cordova platform add windows --save
    1. cordova plugin add https://github.com/serbanghita/cordova-plugin-dialogs.git
    1. cordova build windows
    
    I added `dialogs.js` demo file to the default `index.html` file. Contents of my manual
tests: https://gist.github.com/serbanghita/75de9758eada643ce9823dfa02730066
    
    Here are `prompt` which is close to native `confirm` and `alert` now.
    
    <img width="374" alt="prompt-fix" src="https://cloud.githubusercontent.com/assets/1106849/15019242/ef4c683c-1225-11e6-9bd2-14c14331c613.PNG">
    <img width="380" alt="confirm-native" src="https://cloud.githubusercontent.com/assets/1106849/15019245/f3f0e62e-1225-11e6-9f64-f32c622714f1.PNG">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/serbanghita/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 014dc9ec6d50ea748137201beae0f92b11024382
Author: Serban Ghita <sghita@adobe.com>
Date:   2016-05-04T13:34:45Z

    Separated CSS from JS code.
    Fixed the prompt dialog CSS to look close to native.
    Fixed the positioning of the prompt dialog for Windows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message