cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarangan12 <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-11188: cordova-plugi...
Date Thu, 05 May 2016 18:15:41 GMT
GitHub user sarangan12 opened a pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/43

    CB-11188: cordova-plugin-device-motion-tests are failing in CI

    The error is happening in an assert statement where it tries to compare two timestamp
values. This kind of comparison is risky as there might be slight variations. For eg: 
    
    1. Expected 1462451458702 to be greater than 1462451458723
    2. Expected 1462470496780 to be greater than 1462470496875
    
    In the above examples, you can see the actual value is very close to the expected value.
It is 99.9999 percent of the actual value. But, the test is failing due to the strict comparison.
So, I have changed the assert to accept the actual value is above 95% of the expected value.

    
    @omefire Could you please review and merge this PR?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarangan12/cordova-plugin-device-motion CB-11188

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device-motion/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 98a29cd2ac776d8717f4636f7c7aea09d52c8fe1
Author: Sarangan Rajamanickam <sarajama@microsoft.com>
Date:   2016-05-05T18:11:05Z

    CB-11188: cordova-plugin-device-motion-tests are failing in CI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message