cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kicken <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...
Date Sat, 07 May 2016 23:25:40 GMT
GitHub user kicken opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/210

    CB-10139 browser: Respect target width and height

    Fixes [CB-10139 Camera plugin is cropping image taked from camera in browser platform](https://issues.apache.org/jira/browse/CB-10139).
    
    Cropping occurs due to the canvas's with and height not being set.  This patch sets the
canvas width and height to the values specified in the options given to getPicture.
    
    Tested in recent versions of Chrome, Firefox, and Edge and found no problems.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kicken/cordova-plugin-camera cb-10139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #210
    
----
commit 5ce09dc17ea3c3c11a4a4e099f8ddc6cc8803eb9
Author: Keith M <keithm@aoeex.com>
Date:   2016-05-07T18:36:33Z

    CB-10139 browser: Respect target width and height

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message