cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AnhsirkDasarp <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Fix for - Stretched tool...
Date Wed, 04 May 2016 09:40:01 GMT
GitHub user AnhsirkDasarp opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/166

    Fix for - Stretched tool-bar icons

    The toolbar height param is already set to 44 , So the toolbar icons are stretched. Looks
too weired on small screen devices ( portrait ) 
     [ ref : toolbar.setLayoutParams(new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT,
this.dpToPixels(44))); ]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AnhsirkDasarp/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #166
    
----
commit 90b470194cc4b87348e64afff1acc113c61358d1
Author: Prasad Krishna <prasadkrishna89@gmail.com>
Date:   2016-05-04T09:39:15Z

    Fix for - Stretched tool-bar icons 
    
    The toolbar height param is already set to 44 , So the toolbar icons are stretched. Looks
too weired on small screen devices ( portrait ) 
     [ ref : toolbar.setLayoutParams(new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT,
this.dpToPixels(44))); ]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message