cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (Akvelon)" <v-vlk...@microsoft.com>
Subject RE: Node 6.x and Cordova CLI
Date Tue, 10 May 2016 10:13:02 GMT
Small update.

Looks like failing jshint in https://github.com/apache/cordova-lib/pull/437 is another Node
6.x (In particular npm@3.x) issue. Corresponding bug is filed here: https://github.com/npm/npm/issues/10343.

Hopefully this doesn't affect regular users, as the problem only can be seen when another
cordova dependencies are being linked to cordova-lib. For devs the workaround is to run another
'npm install' inside of 'cordova-common' (and probably other cordova-* modules) after 'npm
install'-ing cordova-lib (see https://github.com/apache/cordova-lib/pull/437/commits/122efe3c561dd5965c54dee5cf0a4c9174870b08)

-
Best regards, Vladimir


-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com] 
Sent: Saturday, May 7, 2016 2:03 AM
To: dev@cordova.apache.org
Subject: RE: Node 6.x and Cordova CLI

Sounds good. I plan on merging fetch PR for the release too.
https://github.com/apache/cordova-lib/pull/407

It is failing on appvoyer but working on my windows machine locally.

I can do discuss release along side tool release if you want. Makes sense to do it together
On May 6, 2016 3:28 PM, "Vladimir Kotikov (Akvelon)" <v-vlkoti@microsoft.com>
wrote:

> That'd be great!
>
> The PRs are ready: https://github.com/apache/cordova-lib/pull/437 and
> https://github.com/apache/cordova-ios/pull/221
> Although the PR for cordova-lib is still failing w/ Node 6.0, this 
> looks like a setup issue (the failure reason is jshint internals) and 
> I can't reproduce these failures on my machine. Also the tests for 
> cordova-lib itself are passing so it should be fine.
>
> -
> Best regards, Vladimir
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Saturday, May 7, 2016 12:19 AM
> To: dev@cordova.apache.org
> Subject: RE: Node 6.x and Cordova CLI
>
> Sweet. Thanks for looking into it! I can start release process for 
> both next week On May 6, 2016 2:13 PM, "Vladimir Kotikov (Akvelon)" < 
> v-vlkoti@microsoft.com>
> wrote:
>
> > Hi list
> >
> > FYI, we’ve recently performed a sanity check of Cordova CLI against 
> > newly released Node JS 6.0 (credits to Alex Sorokin) and found some 
> > issues, caused by new Node JS version. The most critical is a 
> > failure of uninstallation of plugins with custom frameworks for iOS 
> > platform - JIRA
> > CB-11200 [1]. The root cause is the bug in node-xcode which is 
> > already fixed [2].
> >
> > In order to resolve the issue I think we'll need to bump node-xcode 
> > version in both cordova-lib and cordova-ios and release these ASAP.
> > Also we'd probably need to update CI configs to include Node 6.x in 
> > test matrix where possible. I'm going to submit a PR shortly.
> >
> > -
> > [1]
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ue 
> > s.apache.org%2fjira%2fbrowse%2fCB-11200&data=01%7c01%7cv-vlkoti%40mi
> > cr
> > osoft.com%7cc34ccb842dac42d6a7ac08d375f4196e%7c72f988bf86f141af91ab2
> > d7 
> > cd011db47%7c1&sdata=AY47SzHGi2reQtjJRbYU%2b%2fNaKi25qdzw%2fIRW291o12
> > E% 3d [2] https://github.com/alunny/node-xcode/pull/86
> >
> > -
> > Best regards, Vladimir
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Mime
View raw message