cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sinzianag <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-orientation pull request: add Android support for true...
Date Tue, 31 May 2016 21:54:59 GMT
Github user sinzianag commented on the pull request:

    https://github.com/apache/cordova-plugin-device-orientation/pull/19
  
    Most calls to Location Manager require permissions that in android 5.0+ need to be handled
at runtime (ACCESS_COARSE_LOCATION,ACCESS_FINE_LOCATION) and I don't see any code in this
PR that handles that.
    Other plugins seem to be using the [Permission Helper from compat plugin](https://github.com/apache/cordova-plugin-compat/blob/master/src/android/PermissionHelper.java).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message