cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...
Date Wed, 25 May 2016 18:50:16 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221670591
  
    @oddcb, thanks for the contribution!
    This is not an issue though as the `Content-Length` header is set by [`setFixedLengthStreamingMode`](https://developer.android.com/reference/java/net/HttpURLConnection.html?hl=ru#setFixedLengthStreamingMode%28int%29)
in https://github.com/apache/cordova-plugin-file-transfer/blob/9347606dd33fe07ea36799b4dd28804019c68835/src/android/FileTransfer.java#L438.
    I've recently added [tests](https://github.com/apache/cordova-plugin-file-transfer/commit/9347606dd33fe07ea36799b4dd28804019c68835#diff-2a8a5fef3397df87ab538f028a5c6b50R1494)
verifying `Content-Length`, `Content-Type` and `Transfer-Encoding` for multipart/non-multipart
& chunked/non-chunked modes - and they are passing for Android and iOS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message