cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Fri, 20 May 2016 16:49:40 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-220658702
  
    My suggestion was to separate editing and inserting altogether. Continue to have a `config-file`
tag that works exactly like before for adding things to XML, and have a new differently named
tag for editing existing tags (like `edit-config`). The new tag wouldn't specify a parent,
it would use the xpath selector to specify the element to be edited directly. We do lose the
ability to edit a bunch of tags all at once like you say, but I don't think it would be too
cumbersome to add a separate element for each edit we want to make.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message