cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Thu, 19 May 2016 20:20:34 GMT
Github user ktop commented on the pull request:
    @riknoll Vladimir is correct, there is no mechanism for either yet. 
    I think warnings are good, but does that mean the plugins that get installed first get
first dibs to modifying xml elements? How do we go about keeping track of whether or not an
attribute/element was modified or not?
    For the second question, that has actually crossed my mind a few times while testing (how
I couldn't modify the second activity tag or add children to it). I'm not really sure the
best way to handle it. I've thought about adding an identifier attribute to the config-file
tag, but that would limit config-file to modify only one element. 
    <config-file target="AndroidManifest.xml" parent="/manifest/application" identifierName="android:name"
identifierValue="SecondActivity" mode="merge" >
        <activity android:configChanges="orientation|keyboardHidden|screenSize" />
    End goal would be to be able to modify both activity tags in the same config-file tag,
but that may be a stretch. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message