cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11261 Cut out '-nightly' prerelease t...
Date Tue, 17 May 2016 07:17:23 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/440#discussion_r63474049
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -134,15 +134,15 @@ function checkEngines(engines) {
             var engine = engines[i];
     
             // This is a hack to allow plugins with <engine> tag to be installed with
    -        // engine with '-dev' suffix. It is required due to new semver range logic,
    +        // engine with '-dev' or '-nightly' suffixes. It is required due to new semver
range logic,
             // introduced in semver@3.x. For more details see https://github.com/npm/node-semver#prerelease-tags.
             //
             // This may lead to false-positive checks, when engine version with dropped
             // suffix is equal to one of range bounds, for example: 5.1.0-dev >= 5.1.0.
             // However this shouldn't be a problem, because this only should happen in dev
workflow.
    -        engine.currentVersion = engine.currentVersion && engine.currentVersion.replace(/-dev$/,
'');
    -        if ( semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion
=== null ) {
    -            // engine ok!
    +        engine.currentVersion = engine.currentVersion && engine.currentVersion.replace(/-dev|-nightly.*$/,
'');
    +        if ( semver.satisfies(engine.currentVersion, engine.minVersion, /*loose=*/true)
|| engine.currentVersion === null ) {
    --- End diff --
    
    That code is replacing `-dev` suffix in plugin's version, specified in `plugin.xml`. Until
we're not going to publish nightly versions of plugins this should not affect us.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message