cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Improving Windows build output and v...
Date Mon, 16 May 2016 21:10:52 GMT
Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/176#discussion_r63426276
  
    --- Diff: bin/lib/create.js ---
    @@ -46,15 +47,15 @@ module.exports.create = function (destinationDir, config, options)
{
         var root = path.join(__dirname, '..', '..');
     
         events.emit('log', 'Creating Cordova Windows Project:');
    -    events.emit('log', '\tApp Name  : ' + appName);
    -    events.emit('log', '\tNamespace : ' + packageName);
    -    events.emit('log', '\tPath      : ' + projectPath);
    +    events.emit('log', '\tPath: ' + path.relative(process.cwd(), (projectPath || 'CordovaExample')));
    --- End diff --
    
    'CordovaExample' will never be substituted here because projectPath must be truthy after
the checks at the top of this function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message