cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Date Mon, 16 May 2016 19:38:06 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/603#discussion_r63411548
  
    --- Diff: www/docs/en/6.x/config_ref/images.md ---
    @@ -137,15 +140,17 @@ For Windows the recommended approach to define app icons is to use
`target` attr
         </platform>
     ```
     
    -where `source` is the path to the icon which needs to be added.
    +where `src` is the path to the icon which needs to be added.
    +
    +The Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"`
the following files will be copied into the application's `images` folder: `res/windows/storelogo.scale-100.png`,
`res/windows/storelogo.scale-200.png`, etc.
     
    -Please note that Windows platform handles MRT icons automatically, so if you specify
`src="res/windows/storelogo.png"` the following files will be copied into app's `images` folder:
`res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc.
    +TODO Define what MRT is.
     
    -The `target` attribute specifies the base name for resultant icons. For every icon file
destination filename is calculated as `target + '.' + MRT_qualifiers + extension(src)`. For
the icons to display properly in resultant app every `target` value should be the one of icon
filenames, defined in application's `.appxmanifest` file.
    +The `target` attribute specifies the base name for the resultant icons. For every icon
file, its destination filename is calculated as `target + '.' + MRT_qualifiers + extension(src)`.
For the icons to display properly in the application, every `target` value should be one of
the icon filenames defined in the application's `.appxmanifest` file.
     
    -Summarizing the above, using `target` attribute it is possible to:
    +Summarizing the above... using the `target` attribute it is possible to:
    --- End diff --
    
    why '...' instead of ',' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message