cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...
Date Mon, 16 May 2016 08:38:22 GMT
Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63323857
  
    --- Diff: appium-tests/helpers/cameraHelper.js ---
    @@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
         }, opts);
     };
     
    -module.exports.checkPicture = function (pid, cb) {
    +// verifies taken picture when the promise is resolved,
    +// calls a callback with 'OK' if everything is good,
    +// calls a callback with 'ERROR: <error message>' if something is wrong
    +// note that this function is executed in the context of tested app
    +// and not in the context of tests
    +module.exports.checkPicture = function (pid, options, cb) {
    +    var isIos = cordova.platformId === "ios";
    +    var isAndroid = cordova.platformId === "android";
    +    // skip image type check if it's unmodified on Android:
    +    // https://github.com/apache/cordova-plugin-camera/#android-quirks-1
    +    var skipFileTypeCheck = isAndroid &&
    +        (!options.quality || options.quality === 100) &&
    --- End diff --
    
    @riknoll the truth is quality default is 50 for all platforms as if no quality option
is passed, Camera.js set it to 50 (https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js#L145).
Even if the java code sets the default to 80 it will be 50 (I have tested). Anyway, I'm going
to open an issue and set it 50 in the java code too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message