cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...
Date Fri, 13 May 2016 20:57:56 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: template/cordova/lib/MSBuildTools.js ---
    @@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType,
buildarch, o
                 args.push('/p:' + key + '=' + otherConfigProperties[key]);
    +    var that = this;
    -    return spawn(path.join(this.path, 'msbuild'), [projFile].concat(args), { stdio: 'inherit'
    +    // Check if SDK required to build the respective platform is present. If not present,
return with corresponding error, else call msbuild.
    +    if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
    --- End diff --
    These 3 blocks below are almost identical. It could more convenient if `checkPhoneSDK`
and `checkWinSDK` would return a promise, rejected with corresponding error message if SDK
is not found. Then you could just call `check` method and call `spawn` on success.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message