cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...
Date Fri, 13 May 2016 20:39:43 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/177#discussion_r63247817
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -362,6 +362,36 @@ module.exports.run = function () {
         });
     };
     
    +/** Checks if Windows SDK required to build the target_platform is present
    + * @param {String}  target_platorm        Target platform ('8.1' or '10.0')
    + * @return {Boolean}                      Whether the min SDK required to build the platform
is present  
    + *
    + */ 
    +module.exports.isWinSDKPresent = function (target_platform) {
    +    return getInstalledWindowsSdks()
    +    .then(function (installedSdks) {
    +        var reqVersion = Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
    +        var hasSdkInstalled = installedSdks.some(function (installedSdk) {
    +            return installedSdk.eq(reqVersion);
    +        });
    +
    +        return hasSdkInstalled ? true : false;
    --- End diff --
    
    This line is excess. `return installedSdks.some(function (installedSdk) {...` should be
sufficient


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message