cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From colonelchlorine <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...
Date Fri, 13 May 2016 15:13:05 GMT
Github user colonelchlorine commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/270#discussion_r63199991
  
    --- Diff: bin/templates/project/build.gradle ---
    @@ -197,7 +197,12 @@ android {
                     }
                 }
             }
    -    } else if (!cdvVersionCode) {
    +    }
    +    /*
    +
    +    ELSE NOTHING! DON'T MESS WITH THE VERSION CODE IF YOU DON'T HAVE TO!
    --- End diff --
    
    Best piece of code ever written. Why is Cordova doing this in the first place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message