cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Improving Windows build output and v...
Date Thu, 12 May 2016 20:49:25 GMT
Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/176#discussion_r63094515
  
    --- Diff: template/cordova/lib/build.js ---
    @@ -171,11 +171,11 @@ function parseAndValidateArgs(options) {
     
         // Validate args
         if (options.debug && options.release) {
    -        throw new CordovaError('Only one of "debug"/"release" options should be specified');
    +        throw new CordovaError('Cannot specify "debug" and "release" options together.
Please only use one');
    --- End diff --
    
    Nit: Error messages generally shouldn't say "please". I think you can omit this sentence
anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message