cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...
Date Wed, 11 May 2016 21:04:17 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/5#discussion_r62926584
  
    --- Diff: lib/paramedic.js ---
    @@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() {
                 reject(new Error('device is disconnected before passing the tests'));
             });
     
    -        var command = self.getCommandForStartingTests();
    -        logger.normal('cordova-paramedic: running command ' + command);
    -
    -        exec(command, function(code, output) {
    -            if(code) {
    -                // this trace is automatically available in verbose mode
    -                // so we check for this flag to not trace twice
    -                if (!self.config.verbose) {
    -                    logger.normal(output);
    +        return self.getCommandForStartingTests()
    +        .then(function(command){
    +            self.setPermissions();
    +            logger.normal('cordova-paramedic: running command ' + command);
    +            exec(command, function(code, output) {
    +                if(code) {
    +                    // this trace is automatically available in verbose mode
    +                    // so we check for this flag to not trace twice
    +                    if (!self.config.verbose) {
    +                        logger.normal(output);
    +                    }
    +                    logger.normal('cordova-paramedic: unable to run tests; command log
is available above');
    +                    return reject(new Error(command + " returned error code " + code));
                     }
    -                logger.normal('cordova-paramedic: unable to run tests; command log is
available above');
    -                return reject(new Error(command + " returned error code " + code));
    -            }
     
    -            // skip tests if it was just build
    -            if (!self.shouldWaitForTestResult()) {
    -                return resolve(true);
    -            }
    +                // skip tests if it was just build
    +                if (!self.shouldWaitForTestResult()) {
    +                 return resolve(true);
    --- End diff --
    
    @sarangan12 the `return` statement is only indented by one space. Should be indented by
four spaces


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message