cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-11183 Appium tests: Added i...
Date Wed, 11 May 2016 17:56:05 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218538540
  
    It would be nice to refactor the specs a bit, because they seem to be 90% shared code.
This looks pretty good! Reading the file and checking the dimensions covers a lot of the bugs
for camera.
    
    Here are some other things that can be verified:
    
    * Make sure that PNG files and JPEG files are actually encoded/named correctly (check
the headers). We've had bugs in the past where we return a JPEG file with a .png file name
    * Run specs with quality set to 100 in addition to 50. We often treat a quality of 100
as a special case on iOS and Android
    
    It would also be nice to verify the type of URI we get back for the destination type.
Unfortunately, that is horribly inconsistent right now on Android for NATIVE_URI and FILE_URI.
It is possible to get back a `file:` URI, a `content:` URI, or a vanilla path depending on
what camera options you pass. Can we try and verify it on iOS at least?
    
    I think that covers most of the camera options that can be tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message