cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qkdreyer <...@git.apache.org>
Subject [GitHub] cordova-lib pull request:
Date Wed, 11 May 2016 13:37:47 GMT
Github user qkdreyer commented on the pull request:

    https://github.com/apache/cordova-lib/commit/0c61fb097d5f6a317560adbb2165ff916642c5c7#commitcomment-17433959
  
    In cordova-lib/src/cordova/restore-util.js:
    In cordova-lib/src/cordova/restore-util.js on line 117:
    @vladimir-kotikov 
    I suggest replacing it by :
    
    var installFrom = pluginName;
    if (pluginSpec && semver.validRange(pluginSpec, true)) {
        installFrom += '@' + pluginSpec;
    }
    
    But since no version has been specified, we'll be calling plugman.fetch on plugin "PLUGINNAME@~"
resulting to "Error: No compatible version found: PLUGINNAME@'~'" which is a better error
than the previous one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message