cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: Use "cdv_" prefixed scrollView for UIVie...
Date Tue, 10 May 2016 23:36:29 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/187#issuecomment-218323149
  
    I understand why this change should be made. However, since it is part of the public API
(it is part of CDVPlugin), any changes to this will have to go in a major version (the next
will be 5.0).
    
    The original reason this was done (the Category) was as stated in the 4.0 Release Notes:
    https://github.com/apache/cordova-ios/blob/6cc86efbb17f59f2a9626b0867406be697fd47ab/RELEASENOTES.md#400-dec-04-2015
    "Make webView property dynamic in CDVViewController and CDVPlugin (from CDVWebViewEngineProtocol
reference). Added scrollView category to UIView for backwards compatibility reasons."
    
    I believe you also have a typo "cdv_srollView" should be "cdv_scrollView" (missing a 'c'
in scroll)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message