cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Add pull request template
Date Tue, 10 May 2016 20:15:01 GMT
Github user tony-- commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348
  
    There are a couple places that contributor workflow is documented:
    The wiki has a [contributor workflow page](https://wiki.apache.org/cordova/ContributorWorkflow)
which also points to the [issue workflow page](https://wiki.apache.org/cordova/IssueWorkflow).
    The docs have a [Contributor Guidelines page](http://cordova.apache.org/contribute/contribute_guidelines.html).
    
    I guess the wiki pages are pretty much obsolete and the docs workflow is more current.
    
    It seems like it would make sense to at least point to the docs page from the template,
something like:
    "This checklist is intended as a quick reference, for complete details please see our
[Contributor Guidelines](http://cordova.apache.org/contribute/contribute_guidelines.html)".
 
    It would make sense to have the template checklist reflect the outline structure of the
docs page workflow.  I guess this would mean add steps for getting code reviewed, running
tests and commit message guideline.
    
    If any requirements are added (e.g., PR title guideline) or changed as part of this, the
docs should be updated to match the template checklist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message