cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...
Date Tue, 10 May 2016 19:15:04 GMT
Github user riknoll commented on a diff in the pull request:
    --- Diff: lib/utils/utilities.js ---
    @@ -50,10 +50,14 @@ function getSimId() {
         if (findSimResult.code > 0) {
             logger.error("Failed to find simulator we deployed to");
    -        return;
    +        return undefined;
    --- End diff --
    Nitpick: I believe the `undefined` here is redundant. Same thing on line 76.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message