cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: Telemetry
Date Tue, 10 May 2016 16:32:36 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/247#discussion_r62705738
  
    --- Diff: spec/cli.spec.js ---
    @@ -50,19 +56,34 @@ describe("cordova cli", function () {
                 beforeEach(function () {
                 });
     
    -            it("will spit out the version with -v", function () {
    -                cli(["node", "cordova", "-v"]);
    -                expect(console.log.mostRecentCall.args[0]).toMatch(version);
    +            it("will spit out the version with -v", function (done) {
    +                cli(["node", "cordova", "-v"]).then(function() {
    +                    expect(console.log.mostRecentCall.args[0]).toMatch(version);
    +                    done();
    +                }).fail(function() {
    --- End diff --
    
    Can you elaborate why these tests had to be changed and made async?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message