cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TanaseButcaru <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...
Date Fri, 06 May 2016 21:37:13 GMT
Github user TanaseButcaru commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62394372
  
    --- Diff: www/convertUtils.js ---
    @@ -28,10 +28,19 @@ module.exports = {
         */
         toCordovaFormat: function (contact) {
             var value = contact.birthday;
    -        try {
    -          contact.birthday = new Date(parseFloat(value));
    -        } catch (exception){
    -          console.log("Cordova Contact toCordovaFormat error: exception creating date.");
    +        if (value !== null) {
    --- End diff --
    
    I did that null check to skip the part where we enter the try-catch block and try to create
a new Date. I think this has impact on performance, it's faster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message