cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...
Date Fri, 06 May 2016 17:36:18 GMT
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217509068
  
    @rakatyal Is the flakiness related to the host we're XHR'ing to ? Would switching from
'http://cordova-filetransfer.jitsu.com' to something else(e.g: 'http://google.com') solve
this ? If so, let's replace instead of removing the test.
    
    Also, Please add a comment to the tests with @purplecabbage 's comment. It would clarify
why these tests are needed and remind us not to think about removing them in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message