cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11194 Improve cordova load time
Date Wed, 04 May 2016 08:52:01 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/434#discussion_r62007337
  
    --- Diff: cordova-lib/cordova-lib.js ---
    @@ -18,19 +18,35 @@
     */
     
     // For now expose plugman and cordova just as they were in the old repos
    +
    +
    +function addProperty(obj, property, modulePath) {
    --- End diff --
    
    Similar functionality already exists at [`src/cordova/util.js:339`](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/util.js#L339).
There is a slight difference but it looks like it could be reused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message