cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <>
Subject [GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Date Tue, 03 May 2016 17:54:30 GMT
Github user jasongin commented on the pull request:
    All right, I think this is the best we can do. The latest logic copies the file if the
source's last-modified time is >= the target's last-modified time, or if the file sizes
are different. At the time the file gets copied, the target's last-modified time gets set
to the current time, so it is greater than the source's time until the source gets modified
    This should work fine with hooks, because a hook that modifies a file is likely to change
the size, or if it doesn't change the size then the hook is likely to handle the file not
being refreshed. One could contrive an artificial scenario in which the right thing doesn't
happen, but in practice I don't think there would be any issues. And still there will be the
'clean' functionality to fall back on.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message