cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-lib pull request: CB-11194 Improve cordova load time
Date Tue, 03 May 2016 17:04:07 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: cordova-common/src/superspawn.js ---
    @@ -22,7 +22,7 @@ var fs = require('fs');
     var path = require('path');
     var _ = require('underscore');
     var Q = require('q');
    -var shell = require('shelljs');
    +var which = require('shelljs/src/which');
    --- End diff --
    this eliminates multiple copies of `shelljs` - since every module gets it's own version.
There are two versions of cordova-common loaded and hence two shelljs modules.
    If we do update the version of shelljs and this breaks - it would be very obvious to fix.
I have a PR in the works to submit to shelljs to delay load on their side.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message