cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Date Mon, 02 May 2016 19:03:59 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/173#discussion_r61786080
  
    --- Diff: cordova-js-src/platform.js ---
    @@ -56,9 +57,9 @@ module.exports = {
                 // OR cordova.require('cordova/platform').activationContext
                 // activationContext:{type: actType, args: args};
                 var activationHandler = function (e) {
    -                var args = e.detail.arguments;
    -                var actType = e.detail.type;
    -                platform.activationContext = { type: actType, args: args };
    +                // Making all the details available as activationContext
    +                platform.activationContext = utils.clone(e.detail); 
    +                platform.activationContext.args = e.detail.arguments;       /* for backwards
compatibility */
    --- End diff --
    
    Is it intentional that we pass the actual object in as `args`?
    Is that the backwards compatibility part, or is it just that the object has a property
`args` instead of `arguments`
    If so I would prefer `platform.activationContext.args = platform.activationContext.arguments;`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message