cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kenichi-fukushima <>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...
Date Mon, 02 May 2016 06:54:47 GMT
Github user kenichi-fukushima commented on the pull request:
    A drive-by comment:
    In our app, we ended up subclassing CDVWKWebViewEngine and creating another instance of
WKWebView in -pluginInizialize so that we can use configuration values that we want. I'd suggest
factoring out the code to create WKWebViewConfiguration to another method so that Cordova
users can customize the logic by code rather than static configurations in a file. This means
you can't create a web view instance in the initializer any more. This is OK because CDVWKWebViewEngine
doesn't have to conform to the usual plugin semantics and you can add a factory method like

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message