Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dblotsky <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-4-cordova-paramedic@git.apache.org>
In-Reply-To: <git-pr-4-cordova-paramedic@git.apache.org>
Subject: [GitHub] cordova-paramedic pull request: Code changes for Collecting
 Device...
Content-Type: text/plain
Message-Id: <20160413215454.549AFDFC13@git1-us-west.apache.org>
Date: Wed, 13 Apr 2016 21:54:54 +0000 (UTC)

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/4#discussion_r59632979
  
    --- Diff: lib/ParamedicConfig.js ---
    @@ -37,7 +37,12 @@ ParamedicConfig.parseFromArguments = function (argv) {
             endPort:           argv.endport || argv.port,
             externalServerUrl: argv.externalServerUrl,
             reportSavePath:    !!argv.reportSavePath? argv.reportSavePath: undefined,
    -        cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false
    +        cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false,
    +        logPath:           !!argv.logPath? argv.logPath: undefined,
    +        logMins:           !!argv.logMins? argv.logMins: undefined,
    +        appName:           !!argv.appName? argv.appName: undefined,
    +        simulatorsFolder:  !!argv.simulatorsFolder? argv.simulatorsFolder: undefined,
    +        tccDbPath:         !!argv.tccDbPath? argv.tccDbPath: undefined
    --- End diff --
    
    Please add defaults for these properties, or set them to `null` instead of `undefined`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org