Return-Path: 
 <dev-return-58754-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8200D19C8C
	for <apmail-cordova-dev-archive@www.apache.org>;
 Mon, 11 Apr 2016 12:11:04 +0000 (UTC)
Received: (qmail 47101 invoked by uid 500); 11 Apr 2016 12:11:04 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 47061 invoked by uid 500); 11 Apr 2016 12:11:04 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 47050 invoked by uid 99); 11 Apr 2016 12:11:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 12:11:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id BD2DDDFC6F; Mon, 11 Apr 2016 12:11:03 +0000 (UTC)
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-423-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-423-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-11022 Improve performance of
 `cordova...
Content-Type: text/plain
Message-Id: <20160411121103.BD2DDDFC6F@git1-us-west.apache.org>
Date: Mon, 11 Apr 2016 12:11:03 +0000 (UTC)

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/423#issuecomment-208311472
  
    The config file transformations are already handled during both plugin add/rm and prepare. Consider the following code: [Api.js#L233-L237](https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/Api.js#L233-L237). It calls `add_plugin_changes` from [ConfigChanges.js#L128](https://github.com/apache/cordova-lib/blob/master/cordova-common/src/ConfigChanges/ConfigChanges.js#L128) which:
      1. saves these transormations into `<platform>.json` for further usage and
      2.  applies these transformations immediately (see [ConfigChanges.js#L160](https://github.com/apache/cordova-lib/blob/master/cordova-common/src/ConfigChanges/ConfigChanges.js#L160)).
    
    So right now the only goal of calling `prepare` right after `plugin add` is to copy www files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org